Skip to content

Remove Sentry reporting for query limiting

Yorick Peterse requested to merge whitelisting into master

What does this MR do?

This MR removes the ability to report query thresholds to Sentry. From the commit message:

Remove Sentry reporting for query limiting

Using Sentry, while useful, poses two problems you have to choose from:

  1. All errors are reported separately, making it easy to create issues but also making it next to impossible to see other errors (due to the sheer volume of threshold errors).

  2. Errors can be grouped or merged together, reducing the noise. This however also means it's (as far as I can tell) much harder to automatically create GitLab issues from Sentry for the offending controllers.

Since both solutions are terrible I decided to go with a third option: not using Sentry for this at all. Instead we'll investigate using Prometheus alerts and Grafana dashboards for this, which has the added benefit of being able to more accurately measure the behaviour over time.

Note that throwing errors in test environments is still enabled, and whitelisting is still necessary to prevent that from happening (and that in turn still requires that developers create issues).

@marin / @ibaum This should be picked into the next RC if possible, though the changes made by @stanhu should already disable the reporting of errors effectively (this just gets rid of Sentry all together).

Does this MR meet the acceptance criteria?

Edited by Yorick Peterse

Merge request reports