Resolve "404 when listing archived projects in a group where all projects have been archived"
What does this MR do?
This resolves the 404 issue when listing archived project in a group that has all its projects archived.
Are there points in the code the reviewer needs to double check?
I'm still pretty new to this codebase so I'm not sure if there's a specific reason this doesn't already use the same filter function as the sort order.
Why was this MR needed?
We ran into this issue at my company for a legacy subgroup where we want all the projects archived. When trying to view them by selecting either "Show archived projects" or "Show archived projects only" on the group/subgroup page, it would redirect to a invalid URL and 404. For example, viewing the archived projects for something like a group named DevOps, the URL it would try to redirect to would be https://gitlab.datto.net/groups/DevOps/-/children?archived=true. However, the URL had to be https://gitlab.datto.net/groups/DevOps?archived=true to achieve the desired effect. Since the sort filter appended the correct query to the URL, this MR changes the archived project filter to use that same logic.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered -
End-to-end tests pass ( package-qa
manual pipeline job)
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/40623 https://gitlab.com/gitlab-org/gitlab-ee/issues/4248
Closes #40623 (closed)