Skip to content

Honour workhorse provided file name

Alessio Caiazza requested to merge ac/4878-fix-attachments-ext into master

What does this MR do?

Fixes a regression

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

In the attempt to unify file uploading at workhorse level gitlab-workhorse!230 (merged) we moved to a prefix-based tempfile creation in order to avoid upload collisions.

Artifacts and LFS uploads already set original_filename to workhorse provided filename

This MR adds the same feature to Gitlab::Middleware::Multipart

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

gitlab-org/gitlab-ee#4878

Edited by Nick Thomas

Merge request reports