Add noData empty state to Prometheus graphs
What does this MR do?
Adds an empty state to the prometheus graphs in cases where there are no graphs to display. Currently it just shows an empty page with no useful information.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
before | after |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered -
End-to-end tests pass ( package-qa
manual pipeline job)
What are the relevant issue numbers?
Closes: gitlab-org/gitlab-ce#42558
Merge request reports
Activity
@jivanvl @joshlambert could you review this simple change for me real quick... I'd like to merge it and rebase it into gitlab-org/gitlab-ce!16182
Regarding the repurposed graphic for this empty state, if we want to create a new one perhaps we can do so in a follow-up issue. I'd rather get something in here rather than displaying a blank page, and we an iterate later.
assigned to @jivanvl
@mikegreiling LGTM! Thank you for this, should we assign to a maintainer or wait for Josh's answer?
assigned to @mikegreiling
I think it's safe to merge this. @iamphill can you do the honors?
assigned to @iamphill
- Resolved by Phil Hughes
assigned to @mikegreiling
mentioned in commit 364395b3
thanks, @iamphill
added devopsmonitor label