Skip to content
Snippets Groups Projects

Add noData empty state to Prometheus graphs

Merged Mike Greiling requested to merge fix-prometheus-empty-state-no-data into master
All threads resolved!

What does this MR do?

Adds an empty state to the prometheus graphs in cases where there are no graphs to display. Currently it just shows an empty page with no useful information.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

before after
Screen_Shot_2018-01-29_at_1.40.24_PM Screen_Shot_2018-01-29_at_1.39.55_PM

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes: gitlab-org/gitlab-ce#42558

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Phil Hughes resolved all discussions

    resolved all discussions

  • Phil Hughes approved this merge request

    approved this merge request

  • Phil Hughes mentioned in commit 364395b3

    mentioned in commit 364395b3

  • merged

  • Author Contributor

    thanks, @iamphill :thumbsup:

  • Please register or sign in to reply
    Loading