Skip to content

Disable throwOnError in KaTeX to reveal user where is the problem

Jakub Jirutka requested to merge jirutka/gitlab-ce:katex-throwOnError into master

What does this MR do?

From KaTeX documentation:

throwOnError: boolean. If true, KaTeX will throw a ParseError when it encounters an unsupported command. If false, KaTeX will render the unsupported command as text in the color given by errorColor. (default: true)

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

It’s better to render the formula and highlight unsupported commands than just give up and render whole formula as a code; users are confused and don’t know what’s wrong.

Screenshots (if relevant)

Math with unknown command now:

and after this MR is merged:

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Jakub Jirutka

Merge request reports