Don't allow Repository#log with limit zero
What does this MR do?
Removes support for a poorly defined Gitlab::Git::Repository#log option. For good measure, make it an error if anybody passes in this value (limit zero or nil).
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
The old behavior was inconsistent. Rather than supporting that inconsistency, we can remove it.
It is never a good idea to try and create an array holding all the commits on a branch of a repository. The repository may be very large. There should always be some upper limit on how many commits we're loading.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered -
End-to-end tests pass ( package-qamanual pipeline job)
What are the relevant issue numbers?
Edited by Jacob Vosmaer