Skip to content

Remove the wait time for the login form check

Robert Speicher requested to merge qa/rs-remove-login-wait into master

The "Change your password" text is either on the page or it isn't. There's no benefit to using Capybara's default waiting behavior here, as it will never load in via AJAX, for example.

Before:

qa master % CHROME_HEADLESS=false bin/qa Test::Instance http://localhost:3000 qa/specs/features/login/standard_spec.rb
Run options: include {:core=>true}

Randomized with seed 44848

standard user login
  user logs in using credentials

Top 1 slowest examples (14.55 seconds, 100.0% of total time):
  standard user login user logs in using credentials
    14.55 seconds ./qa/specs/features/login/standard_spec.rb:3

Finished in 14.55 seconds (files took 0.4558 seconds to load)
1 example, 0 failures

Randomized with seed 44848

After:

qa master % CHROME_HEADLESS=false bin/qa Test::Instance http://localhost:3000 qa/specs/features/login/standard_spec.rb
Run options: include {:core=>true}

Randomized with seed 45689

standard user login
  user logs in using credentials

Top 1 slowest examples (4.44 seconds, 100.0% of total time):
  standard user login user logs in using credentials
    4.44 seconds ./qa/specs/features/login/standard_spec.rb:3

Finished in 4.44 seconds (files took 0.73518 seconds to load)
1 example, 0 failures

Randomized with seed 45689

Since every example requires this step, it's a good savings now and in the future as we add more test cases.

Merge request reports