Skip to content

Prevent RevList failing on non utf8 paths

James Edwards-Jones requested to merge jej/lfs-rev-list-handles-non-utf-paths-41627 into master

What

Replaces use of path.blank? with !path path.to_s.empty?, as the former fails on paths with non-utf8 characters.

Why

See #41627 (closed)

Are there points in the code the reviewer needs to double check?

We still have output.split("\n") in RevList#execute which will fail if that is used with paths, but this should be fine since we currently only use it for SHAs, and use the lazy version whenever we use --objects which includes paths.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend

What are the relevant issue numbers?

Closes #41627 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports