Skip to content

Don't use Gitlab::Shell#import_repository on local paths

Jacob Vosmaer requested to merge ban-disk-import into master

What does this MR do?

Changes Gitlab::Shell#import_repository to disallow local file imports.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

This method currently either imports from a URL, or a local file. These are very different use cases from a Gitaly point of view. In the local file case we have to worry about how to copy the file to the Gitaly server.

So it makes our life easer if we don't mix these things up.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Jacob Vosmaer

Merge request reports