Skip to content

Don't migrate MR commits or diffs over 100 MB

Sean McGivern requested to merge set-max-size-for-mr-background-migration into master

What does this MR do?

Prevents us from trying to load huge MR diffs when migrating them in the clean-up stage.

Are there points in the code the reviewer needs to double check?

This causes data loss! The only reason we need this is that apparently our staging environment did not complete the background migration correctly, while the production environment did. I'm not actually sure if including this in 10.3.0 is a good idea. It might be better to wait and see if it fails on customer instances, then apply this patch if needed.

Why was this MR needed?

We can't deploy a release candidate to staging because:

  1. The background migration didn't finish for some reason.
  2. Our deploy node has much less memory than our Sidekiq nodes.

Does this MR meet the acceptance criteria?

  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend
    • Has been reviewed by Database

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/41193.

Merge request reports