fix issue #37843
requested to merge dgoo2308/gitlab-ce:37843-ci-trace-ansi-colours-256-bold-have-no-css-due-wrongly-ansi2html-light-color-variant-conversion-feature into master
What does this MR do?
Fix issue #37843 (closed).
Allow bold ANSI 256 colours in the trace output of a build.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
due to a bug in the ansi html converter for the feature: Most terminals show bold coloured text in the light colour variant,
the ANSI 256 colors where also converted:
e.g. xterm-fg-123 to xterm-fg-l-123, whereas there is no CSS entry for xterm-fg-l-xxx resulting bold grey color output for any bold ANSI 256 color.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered
What are the relevant issue numbers?
Closes #37843 (closed)
Edited by Danny