Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !15595

Create fork networks for deleted source projects

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bob Van Landuyt requested to merge bvl-fork-networks-for-deleted-projects into master Nov 24, 2017
  • Overview 6
  • Commits 2
  • Pipelines 5
  • Changes 5

This adjusts the PopulateForkNetworksRange background migration to create fork networks for forks for which the source was deleted.

This allows the forks of those fork to be included in the same network, allowing them to still send merge requests to each other.

It also solves the problem described in https://gitlab.com/gitlab-org/gitlab-ce/issues/40072#note_48335746 in which the background migration to create the fork network memberships for fork of forks would be rescheduled indefinitely.

Database Checklist

When adding migrations:

  • Updated db/schema.rb
  • Added a down method so the migration can be reverted
  • Added the output of the migration(s) to the MR body
== 20171124150326 RescheduleForkNetworkCreation: migrating ====================
-- Populating the `fork_networks` based on existing `forked_project_links`
== 20171124150326 RescheduleForkNetworkCreation: migrated (0.0186s) ===========
  • Added tests for the migration in spec/migrations if necessary (e.g. when migrating data)

General Checklist

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/40072

Edited Nov 27, 2017 by Yorick Peterse
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bvl-fork-networks-for-deleted-projects