Skip to content

Update Prometheus Gem version and disable Prometheus method call instrumentation by default.

What does this MR do?

Latest Prometheus gem version fixes Concurrency and performance problem and has proven to work reliably in test environment. https://gitlab.com/gitlab-org/prometheus-client-mmap/merge_requests/11

But Method Call instrumentation that adds performance measurement to many GitLab internal method calls generates tens of thousands of additional histogram series which cause metrics reading to become quite slow after a while.

To combat this we introduce settings allowing toggling of Method Call tracking using Prometheus metrics.

Additionally, this MR discards CPU time per method time measurement and uses limit to discard any metrics that are below the threshold. In order to further reduce the number of metrics stored in Prometheus.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes: https://gitlab.com/gitlab-org/gitlab-ee/issues/4139, #40457 (closed)

Edited by Paweł Chojnacki

Merge request reports

Loading