Skip to content

Diff note

Simon Knox requested to merge diff-note into master

What does this MR do?

  • convert diff_note_avatar to Single File Component

Are there points in the code the reviewer needs to double check?

  • component needs some more complete tests. @click.native handler wasn't being triggered, and there is a still a bunch of jquery events and dependencies in there that I don't know what to do with

Why was this MR needed?

for diff components to be used in https://gitlab.com/gitlab-org/gitlab-ce/issues/38178

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Simon Knox

Merge request reports