Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !15533

Fix missing MR widget status icons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eric Eastwood requested to merge 40283-fix-missing-mr-widget-status-icons into master Nov 22, 2017
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

What does this MR do?

Fix missing MR widget status icons (update to actually use SVG sprite map)

Before After

Are there points in the code the reviewer needs to double check?

This regressed in https://gitlab.com/gitlab-org/gitlab-ce/commit/d01d509bd8612f9879fa762de8ea3763bcff81cf via https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14567 where we refactored ci_icon.vue to grab the SVG from the sprite instead of a map in ci_status_icons.js

Why was this MR needed?

Status icons were missing in the Merge Request widget.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Frontend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered

What are the relevant issue numbers?

Closes #40283 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 40283-fix-missing-mr-widget-status-icons