Skip to content

Always return full avatar URL for private/internal groups/projects when asset host is set

Douwe Maan requested to merge dm-avatarable-with-asset-host into master

Avatars for private and internal groups and projects require authentication to be viewed, which means they can only be served by Rails, on the regular GitLab host. If an asset host is configured, we need to return the fully qualified URL instead of only the avatar path, so that Rails doesn't prefix it with the asset host.

This is blocking turning on the CDN, so we should get it to production asap, hence ~"Pick into 10.2"

This implementation iterates on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11001 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14443, and adds specs.

Merge request reports