Skip to content

Refactor responsive table styles to support nested error block

What does this MR do?

EE MR, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3251

Refactor responsive table styles to support nested error block. This pattern will be used in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/15064

  • Split layout from the styles of the row
  • Move command .append- .prepend- styles to bottom of source order
    • Actually applies styles over others in more situations which is probably what is expected when you add it to an element
    • Also allows us to get rid of some styles that were trying to get around this fact

Are there points in the code the reviewer needs to double check?

Check any uses of responsive tables and edge case styles.

Before After

Why was this MR needed?

Unable to place a full-width error block below a table row per design of https://gitlab.com/gitlab-org/gitlab-ce/issues/38464

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Eric Eastwood

Merge request reports