Skip to content

Geo route whitelisting is too optimistic

Brett Walker requested to merge 3274-geo-route-whitelisting into master

What does this MR do?

Checks for the specific routes when whilelisting the lfs_route and grack_route by checking for a specific controller/action rather than a hardcoded path.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Certain paths could have been incorrectly whitelisted. An example would be creating new file that ends in the path /info/lfs/objects/batch.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/3274

Edited by Brett Walker

Merge request reports