Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !15051

Fix bitbucket login

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jarka Košanová requested to merge 39495-fix-bitbucket-login into master Oct 26, 2017
  • Overview 8
  • Commits 1
  • Pipelines 2
  • Changes 2

WIP: The fix will be tested on staging today

What does this MR do?

It fixes the login using bitbucket

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

The problem was cause by the update of omniauth-oauth2 which we updated in 10.1 release (https://gitlab.com/gitlab-org/gitlab-ce/commit/5d96b1489e57ee66e50b8ff5ea018264892c8185). As described in https://github.com/intridea/omniauth-oauth2/issues/81 in order to fix it callback_url has to be overrided.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together

What are the relevant issue numbers?

Closes #39495 (closed)

Edited Oct 27, 2017 by Jarka Košanová
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 39495-fix-bitbucket-login