Skip to content

URI decode Page-Title header to preserve UTF-8 characters

Toon Claes requested to merge tc-page-title-encoding-fix into master

What does this MR do?

The Page-Title header has to be ISO-8859-1, so URI encode the characters to they'll be valid ISO-8859-1 and the frontend decodes again to get proper UTF-8 again.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

ApplicationController was trying to convert unavailable characters to ISO-8859-1.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes gitlab-org/gitlab-ce#39179.

Edited by Toon Claes

Merge request reports