Skip to content

Fix errors when deleting a forked project

Bob Van Landuyt requested to merge bvl-fix-deleting-forked-projects into master

What does this MR do?

Fixes a bug updating projects that would appear forked becausde their ForkNetworkMember would exist, but the ForkedProjectLink would not.

Why was this MR needed?

The problem would occur when the ForkedProjectLink was deleted, but the ForkNetworkMember was not. The delete would be rolled back and retried.

But the error would not be saved because Project#forked? would still be true, because the ForkNetworkMember exists. But the Project#forked_project_link would be nil. So the validation for the visibility level would fail.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database

What are the relevant issue numbers?

Closes #39196 (closed)

Edited by Bob Van Landuyt

Merge request reports