Skip to content

Fix confusing double usage of 'metadata'

Jacob Vosmaer requested to merge gitaly-call-kwargs into master

What does this MR do?

Renames a variable and improves method documentation.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

There was a confusing double use of 'metadata' in GitalyClient.call. The function yielded a block argument called 'metadata', which would itself be a hash { metadata: { 'foo' => 'bar' }. This change renames the outer variable to 'kwargs'.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Merge request reports