Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

Scheduled maintenance on the database layer will take place on 2022-07-02. We expect GitLab.com to be unavailable for up to 2 hours starting from 06:00 UTC. Kindly follow our status page for updates and read more in our blog post.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !14642

namespace should be lowercased in kubernetes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mircea Danila Dumitrescu requested to merge venatir/gitlab-ce:master into master Oct 02, 2017
  • Overview 18
  • Commits 1
  • Pipelines 1
  • Changes 2

What does this MR do?

This is making namespace lowercase in kubernetes, otherwise namespaces cannot be created. This was partially addressed, but this covers a case that was missed when the default namespace is generated from the project group-name.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Autodevops fails for projects with uppercase in their name.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together

What are the relevant issue numbers?

Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/38692.

Edited Oct 03, 2017 by Mircea Danila Dumitrescu
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master