GitLab Next

Projects
Groups
Snippets
Help

Loading...
Help
Sign in / Register

GitLab FOSS

Project overview
Repository
Issues 0
Merge Requests 0
- Merge Requests 0
Requirements
Security & Compliance
Operations
Packages & Registries
Analytics
Snippets
- Snippets
Members
- Members

Collapse sidebar

Activity
Graph
Create a new issue
Commits
Issue Boards

GitLab.org
GitLab FOSS
Merge Requests
!14642

Closed

Opened Oct 02, 2017 by Mircea Danila Dumitrescu @venatir2 of 11 tasks completed2/11 tasks

Report abuse

Report abuse

namespace should be lowercased in kubernetes

Overview 18
Commits 1
Pipelines 1
Changes 2

What does this MR do?

This is making namespace lowercase in kubernetes, otherwise namespaces cannot be created. This was partially addressed, but this covers a case that was missed when the default namespace is generated from the project group-name.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Autodevops fails for projects with uppercase in their name.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

Changelog entry added, if necessary
Documentation created/updated
API support added
Tests added for this feature/bug
Review
- Has been reviewed by UX
- Has been reviewed by Frontend
- Has been reviewed by Backend
- Has been reviewed by Database
Conform by the merge request performance guides
Conform by the style guides
Squashed related commits together

What are the relevant issue numbers?

Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/38692.

## What does this MR do?
This is making namespace lowercase in kubernetes, otherwise namespaces cannot be created. This was partially addressed, but this covers a case that was missed when the default namespace is generated from the project group-name.
## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?
Autodevops fails for projects with uppercase in their name.
## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
  - [ ] Has been reviewed by UX
  - [ ] Has been reviewed by Frontend
  - [ ] Has been reviewed by Backend
  - [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/38692.

Edited Oct 03, 2017 by Mircea Danila Dumitrescu

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://gitlab.com/venatir/gitlab-ce.git" "master"
git checkout -b "venatir/gitlab-ce-master" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "venatir/gitlab-ce-master"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Assignee

Assign to

10.2

Milestone

10.2

Assign milestone

Time tracking

3

Labels

Category:Kubernetes Management Community contribution bug

Assign labels

View project labels

Reference: gitlab-org/gitlab-foss!14642