Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !14529

Fixes commit comments in parallel diff view

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Phil Hughes requested to merge commit-side-by-side-comment into master Sep 27, 2017
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 3

What does this MR do?

Fixes a JS bug that would prevent comments from being added to commit diffs when in parallel view.

This was caused by the comment button code from checking against the global notes class, which because of the order of code, was undefined. Instead of relying on this global object the comment button code now does its own check for whether the diff is in parallel view or not.

Why was this MR needed?

Screenshots (if relevant)

2017-09-27_15.39.04

What are the relevant issue numbers?

Closes #38117 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: commit-side-by-side-comment