Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !14423

Fix `rake gitlab:incoming_email:check`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lin Jen-Shin requested to merge 38197-fix-ImapAuthenticationCheck into master Sep 21, 2017
  • Overview 5
  • Commits 1
  • Pipelines 3
  • Changes 2

What does this MR do?

Fix rake gitlab:incoming_email:check and make it report error properly, so that we know what's really wrong.

Are there points in the code the reviewer needs to double check?

  • I think it's fine to show the error message?
  • Do we have tests? I guess not...

Why was this MR needed?

Currently it's broken because config was never defined, and it would be rescued and always report "no".

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend

What are the relevant issue numbers?

Closes #38197 (closed)

Edited Sep 21, 2017 by Lin Jen-Shin
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 38197-fix-ImapAuthenticationCheck