Skip to content

Make GPG validation case insensitive

Tim Bishop requested to merge tdb/gitlab-ce:fix/gpg/case-insensitive into master

What does this MR do?

Fixes validation of GPG signatures when the email address on the GPG key is not all in lower case.

Are there points in the code the reviewer needs to double check?

That I've correctly covered all cases.

Why was this MR needed?

Because GitLab forces addresses to lower-case (in my case, when getting the from LDAP), it means that all email address comparisons need to be case insensitive.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#37009 (moved)

Edited by Dmytro Zaporozhets (DZ)

Merge request reports