Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1
    • Merge Requests 1
  • Requirements
    • Requirements
    • List
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !14255

Merged
Opened Sep 13, 2017 by Eric Eastwood@MadLittleModsContributor6 of 6 tasks completed6/6 tasks

Update "x/x discussions resolved" checkmark icon to be green when all discussions resolved

  • Overview 6
  • Commits 1
  • Pipelines 1
  • Changes 3

What does this MR do?

Update "x/x discussions resolved"(.line-resolve-all) checkmark icon to be green when all discussions resolved.

All discussions resolved? Before After
true
false

Are there points in the code the reviewer needs to double check?

  • Regressed in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13821/diffs#79ea7020ff2bdc6a515cb8c8bf815c6e3e436386_779_785 because we were already styling based on currentColor in the note actions but the line-resolve-all was still using explicit fills.

Why was this MR needed?

  • "x/x discussions resolved" badge checkmark icon wasn't turning green when all discussions were resolved

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together

What are the relevant issue numbers?

Closes #37465 (closed)

Edited Sep 18, 2017 by Eric Eastwood
Assignee
Assign to
Reviewer
Request review from
10.0
Milestone
10.0 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab-foss!14255
Source branch: 37465-fix-line-resolve-all-green-checkmark-icon

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.