Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

Scheduled maintenance on the database layer will take place on 2022-07-02. We expect GitLab.com to be unavailable for up to 2 hours starting from 06:00 UTC. Kindly follow our status page for updates and read more in our blog post.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !13845

Remove skipped examples in filtered issues feature spec

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Robert Speicher requested to merge rs-remove-filtered-issues-skips into master Aug 25, 2017
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

We perform a ton of expensive setup in this spec, via both before and let!. When we use skip inside an it block, rather than skipping the block entirely via xit, we still perform this expensive setup, only to do absolutely nothing with it, resulting in wasted time. Minutes, in this case.

Further, these specs have been sitting in our test suite for about seven months now, so the likelihood of them being addressed soon seems low.

See https://gitlab.com/gitlab-org/gitlab-ce/issues/26546

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: rs-remove-filtered-issues-skips