Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Snippets
  • Register
  • Sign in
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !13821

Update and fix resolvable note icons for easier recognition

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eric Eastwood requested to merge 36582-fix-note-resolved-icon into master Aug 25, 2017
  • Overview 14
  • Commits 1
  • Pipelines 5
  • Changes 6

What does this MR do?

Update and fix resolvable note icons for easier recognition

Before After

Are there points in the code the reviewer needs to double check?

Regressed in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12931/diffs#79ea7020ff2bdc6a515cb8c8bf815c6e3e436386_544_547 where we added the following CSS and icon_status_success.svg wasn't built with external fill in mind.

svg {
  /* ... */
  path {
     fill: currentColor;
  }
}

Why was this MR needed?

Resolvable note icons regressed to filled in circles. UX was inspired by the bug and decided to move to a filled in circle version of the checkmark.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together

What are the relevant issue numbers?

Closes #36582 (closed)

Edited Aug 28, 2017 by Eric Eastwood
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 36582-fix-note-resolved-icon