Improve members view on mobile
What does this MR do?
Improves the members view layout (primarily for mobile but also improves for all views)
Steps to mitigate visual regressions
I made a lot of changes to the partial shared/members/member, so I looked through each of these files that used that partial and double checked them all. Some of them were orphaned and have been removed in a separate MR (!12690 (merged))
$git grep --name-only "shared/members/member
app/views/admin/groups/show.html.haml
app/views/admin/projects/show.html.haml
app/views/groups/group_members/index.html.haml
app/views/groups/group_members/update.js.haml
app/views/projects/project_members/_group_members.html.haml
app/views/projects/project_members/_shared_group_members.html.haml
app/views/projects/project_members/_team.html.haml
app/views/projects/project_members/update.js.haml
app/views/shared/members/_requests.html.hamlAre there points in the code the reviewer needs to double check?
Just the part where I render the css class if the ruby variable is true
Why was this MR needed?
Screenshots (if relevant)
Project Members (Desktop)
URL: /gitlab-org/gitlab-ce/settings/members
| Before | After |
|---|---|
 |
 |
Project Members - Requesting Access (Desktop)
URL: /gitlab-org/gitlab-ce/settings/members
| Before | After |
|---|---|
 |
 |
Project Members (Tablet)
URL: /gitlab-org/gitlab-ce/settings/members
| Before | After |
|---|---|
 |
 |
Project Members - Requesting Access (Tablet)
URL: /gitlab-org/gitlab-ce/settings/members
| Before | After |
|---|---|
 |
 |
Project Members (Mobile)
URL: /gitlab-org/gitlab-ce/settings/members
| Before | After |
|---|---|
 |
 |
Project Members - Requesting Access (Mobile)
URL: /gitlab-org/gitlab-ce/settings/members
| Before | After |
|---|---|
 |
 |
Group Members (Tablet)
URL: groups/gitlab-org/group_members
| Before | After |
|---|---|
 |
 |
Group Members (Mobile)
URL: groups/gitlab-org/group_members
| Before | After |
|---|---|
 |
 |
Admin Group (Desktop)
URL: admin/groups/gitlab-org
| Before | After |
|---|---|
 |
 |
Admin Group (Mobile)
URL: admin/groups/gitlab-org
| Before | After |
|---|---|
|
 |
Admin Project (Mobile)
URL: admin/projects/twitter/flight
| Before | After |
|---|---|
 |
 |
Admin Project - Requesting Access
URL: admin/projects/gitlab-org/gitlab-ce
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #25103 (closed)