Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !12376

Resolve ""Add Members" drop-down doesn't separate Name/Username"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tim Zallmann requested to merge 33981-add-members-drop-down-doesn-t-separate-name-username into master Jun 22, 2017
  • Overview 10
  • Commits 2
  • Pipelines 4
  • Changes 1

What does this MR do?

It fixes + aligns the styling of multi select user items. Spacing + Bold + @ sign changed. I thought about aligning it with the styling of single select but the avatar has s24 on purpose so it looks like a deliberate decision to have the one line format (which makes sense cause you see more results at once).

Screenshots (if relevant)

Before : chrome_2017-06-22_19-37-51

After :
chrome_2017-06-22_19-17-05

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Closes #33981 (moved)

Edited Jun 22, 2017 by Tim Zallmann
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 33981-add-members-drop-down-doesn-t-separate-name-username