Remove implicit dependency on `gitlab_sign_in` assigning to a user instance variable

We shouldn't be using instance variables in specs to begin with, and depending on this implicit behavior of gitlab_sign_in would have made it more difficult to change to sign_in where possible.

...we've also gone ahead and changed to sign_in where possible.