Resolve "Transient karma failure on master for `Date time utils timeFor returns remaining time when in the future`"
requested to merge 33734-transient-karma-failure-on-master-for-date-time-utils-timefor-returns-remaining-time-when-in-the-future into master
What does this MR do?
Fixes a transient job failure in datetime_utility_spec.js
. When calculating timeFor
, if the provided date is 1 year minus 1 second, it will round down and say "11 months remaining" rather than "1 year remaining".
To fix this, we add an additional 10 seconds to the test input.
Are there points in the code the reviewer needs to double check?
the karma
job should pass.
Why was this MR needed?
See above
Screenshots (if relevant)
n/a
Does this MR meet the acceptance criteria?
[ ] Changelog entry added, if necessary[ ] Documentation created/updated[ ] API support added- Tests
[ ] Added for this feature/bug-
All builds are passing
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #33734 (closed)
Edited by Mike Greiling