Skip to content

Update session cookie key name to be unique to instance in development

Eric Eastwood requested to merge 31644-make-cookie-sessions-unique into master

What does this MR do?

  • Update session cookie key name to be unique to instance in development, _gitlab_session_dd3e97794060e2134ec763a0bb3dc6d3bbd011b33ea084ef272498a06c6b80b3
    • Generates hash from Rails.root, thanks @DouweM

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

When working with CE and EE on localhost, signing in to one, invalidates the other because they both overwrite the _gitlab_session cookie.

@MadLittleMods, https://gitlab.com/gitlab-org/gitlab-ce/issues/31644

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #31644 (closed)

Edited by Eric Eastwood

Merge request reports