Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 0
    • Merge requests 0
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !11435

Merged
Created May 17, 2017 by Mark Fletcher@markglenfletcher🔴Maintainer6 of 9 tasks completed6/9 tasks

Resolve "Updating Slack Notification not working by API"

  • Overview 24
  • Commits 5
  • Pipelines 6
  • Changes 4

What does this MR do?

  • New parameters for for chat notification services are accepted by the services API

  • Some cosmetic updates to Service API documentation

  • Add some services missing from the Service API Docs

Are there points in the code the reviewer needs to double check?

Tests. Currently the services tests are very generic. Should further tests be added for these specialised services?

Why was this MR needed?

It's not currently possible to perform the same level of configuration of Chat Notification services via the API as it is through the web interface

Some services were undocumented here

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Closes #32364 (closed) Closes #22306 (closed)

Relates to https://gitlab.com/gitlab-org/gitlab-ee/issues/1120

Assignee
Assign to
Reviewer
Request review from
10.4
Milestone
10.4 (Past due)
Assign milestone
Time tracking
Source branch: 32364-updating-slack-notification-not-working-by-api