Skip to content

Fix bug where backslashes in inline diffs could be dropped

Stan Hu requested to merge stanhu/gitlab-ce:fix-backslashes-inline-diff into master

This MR fixes a bug in inline diff generation causing backslashes to be dropped. For example, the input:

input.to_s.sub(/[\r\n].+/,'').sub(/\\[rn].+/, '').strip

The second backslash is dropped in the second sub statement:

image

With this fix, it looks like:

image

Closes #2253 (closed)

Merge request reports