Enable STARTTLS on Gitlab::LDAP::Adapter (!114) · Merge requests · GitLab.org / GitLab FOSS

The source project of this merge request has been removed.

Katsuhisa Ueda requested to merge (removed):enable_starttls_ldap_adapter into master Jun 03, 2014

Net::LDAP (=0.3.1) supports encryption method 'STARTTLS', but Gitlab::LDAP::Adapter doesn't use it. This causes "Access denied for your LDAP account." on LDAP Signin when LDAP server requires STARTTLS.

This MR fixes Gitlab::LDAP::Adapter can handle both 'ssl' and 'tls' on ldap=>method in gitlab.yml.

For reference, see my slapd.log. before: https://gitlab.com/snippets/1273, after: https://gitlab.com/snippets/1274

Enable STARTTLS on Gitlab::LDAP::Adapter

Merge request reports