Fix transient failure of deployment query spec
requested to merge pchojnacki-gitlab/gitlab-ce:32231-fix-transient-failure-of-deployment-query-spec into master
Are there points in the code the reviewer needs to double check?
I've looked into few avenues and the only thing that comes to my mind is that different deployments with the same id's are returned. One for Rspec context and other for Sidekiq job. They seem to only differ with creation time.
I've mocked find_by
that sidekiq based query uses to make sure I return the same instance that is used in rspec.
Why was this MR needed?
Transient failures
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
[ ] Changelog entry added, if necessary[ ] Documentation created/updated[ ] API support added- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #32231 (closed)