Skip to content

Removed all instances of Object.assign by using es6 classes, also includes some …

Luke Bennett requested to merge remove-droplab-object-assign-calls into master

What does this MR do?

Today I saw a very strange error suggesting that Object.assign was undefined. I don't know how this is possible and haven't been able to debug very deep. This is an experimental fix that removes our uses of Object.assign and uses the class keyword instead.

I also removed the eslint-disable on these files as there were just a few linter changes to make.

https://gitlab.com/gitlab-org/gitlab-ce/builds/16057434

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Merge request reports