Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !10936

Fix ordering of commits in the network graph.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timothy Andrew requested to merge 30973-fix-network-graph-ordering into master Apr 26, 2017
  • Overview 13
  • Commits 2
  • Pipelines 4
  • Changes 5

What does this MR do?

  • We upgraded rugged to 0.25.1.1 in !10286 (merged) for %9.1

  • Prior to this upgrade, the default sort order for commits returned by Gitlab::Git::Repository#find_commits was Rugged::SORT_DATE, which the graph relied on.

  • While upgrading rugged, the MR also changed this default to Rugged::SORT_NONE, which broke commit ordering in the graph.

  • This MR adds an option to Gitlab::Git::Repository#find_commits to sort by date, and changes the graph builder Network::Graph so it explictly requests the :date sort order

What are the relevant issue numbers?

Closes #30973 (closed)

Tasks

  • Investigation
  • Implementation
  • Tests
    • Added
      • Add more tests for Network::Graph
      • Compare results of this fix v/s 9.0 and confirm that there are no changes
    • Passing
  • Meta
    • CHANGELOG entry created
    • API support added
    • Branch has no merge conflicts with master
    • Squashed related commits together
    • Added screenshots
    • Check for clean merge with EE
    • Documentation added/updated
  • Review
    • Reviewer
    • Maintainer
  • Wait for merge
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 30973-fix-network-graph-ordering