Refactor rich blob viewers and add Code|Rendered switch
-
Review changes -
-
Download -
Patches
-
Plain diff
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24287
EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1720
After https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10563, and while waiting for the build for https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1556 to succeed, I couldn't help myself.
We now have:
- a totally refactored backend for
BlobViewer
s, - a Source|Rendered switch that shows "Rendered" by default, except when the URL anchor starts with
#L
, which means line number anchors now work to link to specific lines in Markdown source! - a file size limit of 10MB on client-side rendered files, so we don't force users to download huge files,
- and a
.blob-viewer[data-type=simple]
that rich JS viewers can fall back to when the rich rendering fails for whatever reason. They shouldhide()
their own blob viewer (.blob-viewer[data-type=rich]
) and the switch buttons (.js-blob-viewer-switcher
), andshow()
that simple fallback viewer, which will be the regular Download or Text view.
To do:
-
Split up in a sensible way -
Specs
The switch can be seen in action with SVG, but also supported for Markdown and IPython Notebooks, as well as other supported Markup formats:
Merge request reports
Compare and
Show latest version
- version 45b6566277
- version 449b905516
- version 4366b9a102
- version 424c746614
- version 4103ab1742
- version 40ea5d88a3
- version 39ee9380f4
- version 381ff882e4
- version 377e67069b
- version 367e67069b
- version 3598053298
- version 3498053298
- version 337326155c
- version 32f1bc9d48
- version 31954a1fc2
- version 30c9fdb9cd
- version 292bbcdfbf
- version 28e4a5f6d0
- version 27b79afe4c
- version 26c7c6925a
- version 2598675434
- version 24b89893b4
- version 230749f91b
- version 2290663a75
- version 21ad35659c
- version 20499b141c
- version 19b0eec3c6
- version 18af77ea01
- version 174584c686
- version 16e4158aab
- version 15e9da0715
- version 141f52bcb6
- version 133e4bfeba
- version 1229e847d6
- version 1129e847d6
- version 104767c509
- version 90f057c2b
- version 8c0b070db
- version 74ef228db
- version 6cb0d49cd
- version 51ec42c7b
- version 4feec21c8
- version 394499532
- version 2487a2ad0
- version 159268cd8
- master (base)
- latest versionbb78652736 commits,
- version 45b656627735 commits,
- version 449b90551635 commits,
- version 4366b9a10234 commits,
- version 424c74661433 commits,
- version 4103ab174233 commits,
- version 40ea5d88a330 commits,
- version 39ee9380f429 commits,
- version 381ff882e428 commits,
- version 377e67069b26 commits,
- version 367e67069b26 commits,
- version 359805329822 commits,
- version 349805329822 commits,
- version 337326155c21 commits,
- version 32f1bc9d4820 commits,
- version 31954a1fc218 commits,
- version 30c9fdb9cd14 commits,
- version 292bbcdfbf13 commits,
- version 28e4a5f6d014 commits,
- version 27b79afe4c16 commits,
- version 26c7c6925a23 commits,
- version 259867543429 commits,
- version 24b89893b427 commits,
- version 230749f91b25 commits,
- version 2290663a7524 commits,
- version 21ad35659c23 commits,
- version 20499b141c22 commits,
- version 19b0eec3c620 commits,
- version 18af77ea0119 commits,
- version 174584c68618 commits,
- version 16e4158aab16 commits,
- version 15e9da071515 commits,
- version 141f52bcb610 commits,
- version 133e4bfeba9 commits,
- version 1229e847d68 commits,
- version 1129e847d68 commits,
- version 104767c5096 commits,
- version 90f057c2b5 commits,
- version 8c0b070db4 commits,
- version 74ef228db3 commits,
- version 6cb0d49cd2 commits,
- version 51ec42c7b2 commits,
- version 4feec21c82 commits,
- version 3944995323 commits,
- version 2487a2ad02 commits,
- version 159268cd82 commits,
Compare changes
- Side-by-side
- Inline
Files
324Loading