Skip to content
Snippets Groups Projects

Don't show 'Copy content' button on text files that are not rendered as text

Merged Douwe Maan requested to merge dm-remove-copy-link-on-svgs into master
All threads resolved!

Bug introduced in !9878 (merged).

The "Copy content" button reads the content to copy from the DOM, and can only do that when the actual blob/_text partial is displayed, and not if the textfile is rendered as, say, SVG or Markdown.

The large amount of changes was "necessary" to make sure Blob#to_partial_path actually only returns text when it's actually going to render as text.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robert Speicher resolved all discussions

    resolved all discussions

  • @DouweM Merged, check the EE compatibility please.

  • Robert Speicher mentioned in commit 84da388d

    mentioned in commit 84da388d

  • Picked into 9-1-stable, will go into 9.1-RC1

  • Felipe Cardozo removed ~149423 label

    removed ~149423 label

  • Robert Speicher mentioned in commit 16c2896b

    mentioned in commit 16c2896b

  • Please register or sign in to reply
    Loading