Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !10389

Fix race condition where a namespace would be deleted before a project was deleted

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Stan Hu requested to merge sh-fix-destroy-user-race into master Apr 01, 2017
  • Overview 5
  • Commits 2
  • Pipelines 11
  • Changes 7

When deleting a user, the following sequence could happen:

  1. Project mygroup/myproject is scheduled for deletion
  2. The group mygroup is deleted
  3. Sidekiq worker runs to delete mygroup/myproject, but the namespace and routes have been destroyed.

Closes #30334 (closed)

This may also close #30306 (closed), since the deletion of the namespace and project should no longer result in a deadlock.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: sh-fix-destroy-user-race