Resolve "Add more tests for spec/controllers/projects/builds_controller_spec.rb"
requested to merge shinya.maeda/gitlab-ce:29181-add-more-tests-for-spec-controllers-projects-builds-controller-spec-rb into master
What does this MR do?
- Add more tests for spec/controllers/projects/builds_controller_spec.rb
- Fix easy bugs
- Clarify concerns involved with builds_controller_spec
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #29181 (closed)