Skip to content

Cleanup Notify spec and combine multiple examples into one

Robert Speicher requested to merge rs-notify-mailer-specs into master

See individual commits for details and reasoning.

Before:

Factory usage counts:
   #<user average_time=0.032 count=1456>
   #<creator average_time=0.028 count=522>
   #<owner average_time=0.029 count=506>
   #<namespace average_time=0.035 count=506>
   #<project average_time=0.109 count=466>
   #<issue average_time=0.038 count=260>
   #<author average_time=0.029 count=195>
   #<merge_request average_time=0.124 count=174>
   #<note average_time=0.05 count=85>
   #<group average_time=0.009 count=56>
   #<empty_project average_time=0.082 count=56>
   #<project_member average_time=0.014 count=32>
   #<group_member average_time=0.016 count=32>
   #<diff_note_on_merge_request average_time=0.231 count=16>
   #<diff_note_on_commit average_time=0.073 count=14>

Finished in 2 minutes 58.5 seconds (files took 0.80641 seconds to load)
554 examples, 0 failures

After:

Factory usage counts:
   #<user average_time=0.034 count=820>
   #<creator average_time=0.029 count=299>
   #<owner average_time=0.029 count=291>
   #<namespace average_time=0.036 count=291>
   #<project average_time=0.112 count=270>
   #<issue average_time=0.038 count=149>
   #<author average_time=0.03 count=115>
   #<merge_request average_time=0.129 count=100>
   #<note average_time=0.053 count=50>
   #<empty_project average_time=0.082 count=29>
   #<group average_time=0.011 count=28>
   #<project_member average_time=0.015 count=16>
   #<group_member average_time=0.032 count=16>
   #<diff_note_on_merge_request average_time=0.242 count=11>
   #<diff_note_on_commit average_time=0.071 count=10>

Finished in 1 minute 50.46 seconds (files took 0.82425 seconds to load)
314 examples, 0 failures

Merge request reports