Mention migration specs failing in master
Job #1473805048 failed for f397d486:
Happening to:
spec/migrations/migrate_merge_request_mentions_to_db_spec.rb
spec/migrations/migrate_all_merge_request_user_mentions_to_db_spec.rb
spec/lib/gitlab/background_migration/user_mentions/create_resource_user_mention_spec.rb
spec/migrations/migrate_commit_notes_mentions_to_db_spec.rb
1) MigrateAllMergeRequestUserMentionsToDb behaves like schedules resource mentions migration schedules background migrations
Failure/Error:
expect do
Gitlab::BackgroundMigration.perform(migration, arguments)
end.not_to raise_error
expected no Exception, got #<ArgumentError: comparison of Integer with nil failed> with backtrace:
# ./lib/gitlab/markdown_cache/active_record/extension.rb:42:in `<'
# ./lib/gitlab/markdown_cache/active_record/extension.rb:42:in `save_markdown'
# ./app/models/concerns/cache_markdown_field.rb:73:in `refresh_markdown_cache!'
# ./app/models/concerns/cache_markdown_field.rb:123:in `updated_cached_html_for'
# ./lib/gitlab/background_migration/user_mentions/models/concerns/isolated_mentionable.rb:53:in `block in all_references'
# ./lib/gitlab/background_migration/user_mentions/models/concerns/isolated_mentionable.rb:45:in `each'
# ./lib/gitlab/background_migration/user_mentions/models/concerns/isolated_mentionable.rb:45:in `all_references'
# ./lib/gitlab/background_migration/user_mentions/models/concerns/isolated_mentionable.rb:71:in `build_mention_values'
# ./lib/gitlab/background_migration/user_mentions/create_resource_user_mention.rb:26:in `block (2 levels) in perform'
# ./lib/gitlab/background_migration/user_mentions/create_resource_user_mention.rb:25:in `block in perform'
# ./app/models/concerns/each_batch.rb:94:in `block in each_batch'
# ./app/models/concerns/each_batch.rb:68:in `step'
# ./app/models/concerns/each_batch.rb:68:in `each_batch'
# ./lib/gitlab/background_migration/user_mentions/create_resource_user_mention.rb:23:in `perform'
# ./lib/gitlab/background_migration.rb:59:in `perform'
# ./spec/support/matchers/background_migrations_matchers.rb:6:in `block (3 levels) in <top (required)>'
# ./spec/support/matchers/background_migrations_matchers.rb:5:in `block (2 levels) in <top (required)>'
# ./spec/support/matchers/background_migrations_matchers.rb:13:in `block (2 levels) in <top (required)>'
# ./spec/support/shared_examples/lib/gitlab/background_migration/mentions_migration_shared_examples.rb:78:in `block (4 levels) in <top (required)>'
# ./spec/support/shared_examples/lib/gitlab/background_migration/mentions_migration_shared_examples.rb:67:in `block (3 levels) in <top (required)>'
# ./spec/support/shared_examples/lib/gitlab/background_migration/mentions_migration_shared_examples.rb:66:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:390:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:381:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:377:in `block (3 levels) in <top (required)>'
# ./lib/gitlab/application_context.rb:31:in `with_raw_context'
# ./spec/spec_helper.rb:377:in `block (2 levels) in <top (required)>'
# ./spec/support/database_cleaner.rb:60:in `block (2 levels) in <top (required)>'