Follow-up from "Resolve "Multi selection for delete on registry page""
The following discussion from !30837 (merged) should be addressed:
-
@tkuah started a discussion: (+4 comments) We can effectively achieve something similar with using strong params. Something like:
def bulk_destroy # ... end private def bulk_destroy_params params.require(:ids) end
I would also suggest we move all the logic into a service class
Projects::ContainerRepository::Tags::DestroyService
def bulk_destroy destroyed_tags = Projects::ContainerRepository::Tags::DestroyService.new(project, current_user, bulk_destroy_params) respond_to do |format| format.json { head(success_count == @destroyed_tags.size ? :no_content : :bad_request) } end end