Wrong CI status indicator on project pages in presence of warnings
Summary
The CI status indicator on project pages or in the commit history is wrongly displayed as "passed" (green check mark) if warnings are present.
Steps to reproduce
Define a project with a GitLab CI configuration containing at least two stages, whereas the first stage is allowed to fail softly (allow_failure: true
).
What is the current bug behavior?
The status of CI pipelines with soft-failed stages is incorrectly displayed as "passed" (green check mark) on project pages or in the commit history, but correctly displayed in the activity stream as "passed with warnings" (orange exclamation mark).
What is the expected correct behavior?
The correct CI status "passed with warnings" (orange exclamation mark) should be displayed consistently everywhere.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 16.04 Proxy: no Current User: git Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.21.0 Sidekiq Version:5.2.7 Go Version: unknownGitLab information Version: 12.1.1-ee Revision: b49d6585894 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.7 URL: [REDACTED] HTTP Clone URL: [REDACTED] SSH Clone URL: [REDACTED] Elasticsearch: no Geo: no Using LDAP: yes Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 9.3.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 9.3.0 ? ... OK (9.3.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... Server: ldapmain LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results) User output sanitized. Found 76 users of 100 limit.
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 5/6 ... yes 7/9 ... yes 6/11 ... yes 6/12 ... yes 6/13 ... yes 6/14 ... yes 9/16 ... yes 10/17 ... yes 10/18 ... yes 17/30 ... yes 79/31 ... yes 79/32 ... yes 79/33 ... yes 79/34 ... yes 79/35 ... yes 79/36 ... yes 17/38 ... yes 17/39 ... yes 17/40 ... yes 131/41 ... yes 26/46 ... yes 26/47 ... yes 26/48 ... yes 26/49 ... yes 26/50 ... yes 26/51 ... yes 26/52 ... yes 26/53 ... yes 26/54 ... yes 26/55 ... yes 26/56 ... yes 26/58 ... yes 26/59 ... yes 26/60 ... yes 26/61 ... yes 26/62 ... yes 26/63 ... yes 26/64 ... yes 17/66 ... yes 17/68 ... yes 17/69 ... yes 24/71 ... yes 7/73 ... yes 10/77 ... yes 12/79 ... yes 15/82 ... yes 7/83 ... yes 130/84 ... yes 26/86 ... yes 26/87 ... yes 26/88 ... yes 26/89 ... yes 26/90 ... yes 26/91 ... yes 26/92 ... yes 35/94 ... yes 12/96 ... yes 23/97 ... yes 26/98 ... yes 41/101 ... yes 5/104 ... yes 35/105 ... yes 127/108 ... yes 35/109 ... yes 59/112 ... yes 60/113 ... yes 127/114 ... yes 17/115 ... yes 68/116 ... yes 79/119 ... yes 26/120 ... yes 69/122 ... yes 5/123 ... yes 60/124 ... yes 17/128 ... yes 17/129 ... yes 79/130 ... yes 94/131 ... yes 7/136 ... yes 9/138 ... yes 24/146 ... yes 79/148 ... yes 80/149 ... yes 68/150 ... yes 79/151 ... yes 35/152 ... yes 127/154 ... yes 2/155 ... yes 74/258 ... yes 78/259 ... yes 78/260 ... yes 83/261 ... yes 130/383 ... yes 85/384 ... yes 79/386 ... yes 79/387 ... yes 79/388 ... yes 79/389 ... yes 79/390 ... yes 79/391 ... yes 79/392 ... yes 79/393 ... yes 68/395 ... yes 2/396 ... yes 90/397 ... yes 127/398 ... yes 26/399 ... yes 118/400 ... yes 10/401 ... yes 96/402 ... yes 79/403 ... yes 79/404 ... yes 79/405 ... yes 130/406 ... yes 80/408 ... yes 96/409 ... yes 13/410 ... yes 98/412 ... yes 23/413 ... yes 118/414 ... yes 25/415 ... yes 25/416 ... yes 25/417 ... yes 25/418 ... yes 25/419 ... yes 25/420 ... yes 25/421 ... yes 25/422 ... yes 25/423 ... yes 25/424 ... yes 25/425 ... yes 25/426 ... yes 25/427 ... yes 25/428 ... yes 25/429 ... yes 25/430 ... yes 25/431 ... yes 25/432 ... yes 25/433 ... yes 25/434 ... yes 25/435 ... yes 25/436 ... yes 25/437 ... yes 25/438 ... yes 25/439 ... yes 25/440 ... yes 25/441 ... yes 25/442 ... yes 25/443 ... yes 25/444 ... yes 25/445 ... yes 25/446 ... yes 25/447 ... yes 25/448 ... yes 25/449 ... yes 25/450 ... yes 25/451 ... yes 25/452 ... yes 25/453 ... yes 25/454 ... yes 25/455 ... yes 25/456 ... yes 25/457 ... yes 25/458 ... yes 25/459 ... yes 25/460 ... yes 25/461 ... yes 25/462 ... yes 25/463 ... yes 25/464 ... yes 25/465 ... yes 25/466 ... yes 25/467 ... yes 25/468 ... yes 25/469 ... yes 25/470 ... yes 25/471 ... yes 25/472 ... yes 25/473 ... yes 25/474 ... yes 25/475 ... yes 25/476 ... yes 25/477 ... yes 25/478 ... yes 25/479 ... yes 25/480 ... yes 25/481 ... yes 25/482 ... yes 25/483 ... yes 25/484 ... yes 25/485 ... yes 25/486 ... yes 25/487 ... yes 25/488 ... yes 41/489 ... yes 127/490 ... yes 127/491 ... yes 26/492 ... yes 94/493 ... yes 26/494 ... yes 23/496 ... yes 14/497 ... yes 91/498 ... yes 83/499 ... yes 94/500 ... yes 21/501 ... yes 104/502 ... yes 127/503 ... yes 58/504 ... yes 130/505 ... yes 58/506 ... yes 104/507 ... yes 35/509 ... yes 26/510 ... yes 108/511 ... yes 2/512 ... yes 114/513 ... yes 114/514 ... yes 26/515 ... yes 108/516 ... yes 90/517 ... yes 35/518 ... yes 83/519 ... yes 104/521 ... yes 74/522 ... yes 83/523 ... yes 107/525 ... yes 114/526 ... yes 116/527 ... yes 91/528 ... yes 25/529 ... yes 25/530 ... yes 25/531 ... yes 25/532 ... yes 25/533 ... yes 25/534 ... yes 25/535 ... yes 25/536 ... yes 25/537 ... yes 25/538 ... yes 25/539 ... yes 25/540 ... yes 25/541 ... yes 25/542 ... yes 25/543 ... yes 25/544 ... yes 25/545 ... yes 25/546 ... yes 25/547 ... yes 117/548 ... yes 117/549 ... yes 117/550 ... yes 117/551 ... yes 26/552 ... yes 117/553 ... yes 26/554 ... yes 127/555 ... yes 127/556 ... yes 120/557 ... yes 120/558 ... yes 120/559 ... yes 121/560 ... yes 121/561 ... yes 19/562 ... yes 128/564 ... yes 133/565 ... yes 129/566 ... yes 118/567 ... yes 128/568 ... yes 79/570 ... yes 131/573 ... yes 83/574 ... yes 121/575 ... yes 134/576 ... yes 135/577 ... yes 107/578 ... yes 107/579 ... yes 21/580 ... yes 135/581 ... yes 127/582 ... yes 127/583 ... yes 127/584 ... yes 21/585 ... yes 35/586 ... yes 139/587 ... yes 131/588 ... yes 140/589 ... yes 142/590 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.3) Git version >= 2.21.0 ? ... yes (2.21.0) Git user has default SSH configuration? ... yes Active users: ... 70 Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished