when closing or reopening merge request, there was 500 error
Summary
when i closed or reopened a merge request, 500 error happened. but the request was actually closed or reopened.
Steps to reproduce
project --> merge request --> close merge request (or reopen merge request)
Relevant logs and/or screenshots
Parameters: {"merge_request"=>{}, "namespace_id"=>"marketing", "project_id"=>"b2b", "id"=>"1"}
[ActiveJob] [ActionMailer::DeliveryJob] [79e08543-f27e-43eb-bffe-ca201f4b783e] Performing ActionMailer::DeliveryJob (Job ID: 79e08543-f27e-43eb-bffe-ca201f4b783e) from Sidekiq(mailers) with arguments: "Notify", "note_merge_request_email", "deliver_now", 12, 4
[ActiveJob] Enqueued ActionMailer::DeliveryJob (Job ID: 79e08543-f27e-43eb-bffe-ca201f4b783e) to Sidekiq(mailers) with arguments: "Notify", "note_merge_request_email", "deliver_now", 12, 4
[ActiveJob] [ActionMailer::DeliveryJob] [3b054f03-69e1-4d5f-a058-a1c4afaf8be9] Performing ActionMailer::DeliveryJob (Job ID: 3b054f03-69e1-4d5f-a058-a1c4afaf8be9) from Sidekiq(mailers) with arguments: "Notify", "note_merge_request_email", "deliver_now", 16, 4
[ActiveJob] Enqueued ActionMailer::DeliveryJob (Job ID: 3b054f03-69e1-4d5f-a058-a1c4afaf8be9) to Sidekiq(mailers) with arguments: "Notify", "note_merge_request_email", "deliver_now", 16, 4
Completed 500 Internal Server Error in 104ms (ActiveRecord: 58.2ms)
FrozenError (can't modify frozen String):
app/services/system_note_service.rb:245:in `change_status'
app/services/merge_requests/base_service.rb:6:in `create_note'
lib/gitlab/metrics/instrumentation.rb:161:in `block in create_note'
lib/gitlab/metrics/method_call.rb:36:in `measure'
lib/gitlab/metrics/instrumentation.rb:161:in `create_note'
app/services/merge_requests/close_service.rb:14:in `execute'
lib/gitlab/metrics/instrumentation.rb:161:in `block in execute'
lib/gitlab/metrics/method_call.rb:36:in `measure'
lib/gitlab/metrics/instrumentation.rb:161:in `execute'
app/services/issuable_base_service.rb:315:in `change_state'
app/services/issuable_base_service.rb:194:in `update'
app/services/merge_requests/update_service.rb:24:in `execute'
lib/gitlab/metrics/instrumentation.rb:161:in `block in execute'
lib/gitlab/metrics/method_call.rb:36:in `measure'
lib/gitlab/metrics/instrumentation.rb:161:in `execute'
app/controllers/projects/merge_requests_controller.rb:109:in `update'
lib/gitlab/session.rb:11:in `with_session'
app/controllers/application_controller.rb:445:in `set_session_storage'
lib/gitlab/i18n.rb:55:in `with_locale'
lib/gitlab/i18n.rb:61:in `with_user_locale'
app/controllers/application_controller.rb:439:in `set_locale'
lib/gitlab/middleware/rails_queue_duration.rb:27:in `call'
lib/gitlab/metrics/rack_middleware.rb:17:in `block in call'
lib/gitlab/metrics/transaction.rb:57:in `run'
lib/gitlab/metrics/rack_middleware.rb:17:in `call'
lib/gitlab/middleware/multipart.rb:103:in `call'
lib/gitlab/request_profiler/middleware.rb:16:in `call'
lib/gitlab/middleware/go.rb:20:in `call'
lib/gitlab/etag_caching/middleware.rb:13:in `call'
lib/gitlab/middleware/correlation_id.rb:16:in `block in call'
lib/gitlab/middleware/correlation_id.rb:15:in `call'
lib/gitlab/middleware/read_only/controller.rb:40:in `call'
lib/gitlab/middleware/read_only.rb:18:in `call'
lib/gitlab/middleware/basic_health_check.rb:25:in `call'
lib/gitlab/request_context.rb:26:in `call'
lib/gitlab/metrics/requests_rack_middleware.rb:29:in `call'
lib/gitlab/middleware/release_env.rb:12:in `call'
Completed 200 OK in 159ms (Views: 2.0ms | ActiveRecord: 90.6ms)
Completed 200 OK in 210ms (Views: 0.9ms | ActiveRecord: 66.0ms)
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: CentOS 7.6.1810 Current User: git Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.21.0 Sidekiq Version:5.2.7 Go Version: unknownGitLab information Version: 12.0.2 Revision: 1a9fd38a4ca Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.7 URL: http://some-domain.com HTTP Clone URL: http://some-domain.com:8000/some-group/some-project.git SSH Clone URL: git@some-domain.com:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 9.3.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 9.3.0 ? ... OK (9.3.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet) Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 16/5 ... yes 16/7 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.3) Git version >= 2.21.0 ? ... yes (2.21.0) Git user has default SSH configuration? ... yes Active users: ... 9
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished