Fix the following style-lint errors and warnings for `app/assets/stylesheets/framework/forms.scss`
Problem
Fix the following style-lint errors and warnings for app/assets/stylesheets/framework/forms.scss
45:3 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
49:3 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
95:3 ⚠ Expected ".help-form .form-group .input-group-prepend .btn" to have no more than 3 compound selectors selector-max-compound-selectors
95:3 ⚠ Expected ".help-form .form-group .input-group-append .btn" to have no more than 3 compound selectors selector-max-compound-selectors
106:5 ⚠ Expected ".help-form .form-group .text-block code" to have no more than 3 compound selectors selector-max-compound-selectors
110:5 ⚠ Expected ".help-form .form-group .text-block img" to have no more than 3 compound selectors selector-max-compound-selectors
238:3 ⚠ ".gl-field-error-message" and ".gl-field-error (app/assets/stylesheets/framework/forms.scss -207:1)" have the same stylelint-gitlab/duplicate-selectors
properties.
255:1 ⚠ ".input-icon-wrapper" and ".select-wrapper (app/assets/stylesheets/framework/forms.scss -143:1)" have the same properties. stylelint-gitlab/duplicate-selectors
What to do
- If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
- Double check if all the warning have been fixed by running
yarn run stylelint-file app/assets/stylesheets/framework/forms.scss
- In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
- If there are a lot of changes, we recommend to break them into smaller MRs
- Double check the usage of each changed class both in CE and EE
- EE changes should either be backported into CE or moved into
ee/
folder. You can read more about how to handle EE code here - Label the MR with CSS cleanup